Update units to be consistent. (#78)

* Fix Quijote units

* Updates to units

* Fix how things are loaded

* Updating definitions & conventions

* Clear up how fiducial observers in quijote work

* Refactorize array manip

* Move function definition

* More code refactoring

* Remove unused argument

* Remove `convert_from_box`

* Make a note

* Converting particle units

* Add notes about units

* Remove box constants

* Add rho_crit0

* Fix spherical overdensity mass units

* Refactor more code

* Edit catalogue kwargs

* Edit the docstring

* Edit bounds

* Add new checks for empty array

* Remove unused import

* Remove old code

* Remove old function

* Update real 2 redshift

* Clear up the RSP conv

* Add comments

* Add some units

scripts/pre_sortinit.py

@@ -12,9 +12,13 @@
 # You should have received a copy of the GNU General Public License along
 # with this program; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
-"""
+r"""
 Script to sort the initial snapshot particles according to their final
 snapshot ordering, which is sorted by the halo IDs.
+
+Ensures the following units:
+    - Positions in box units.
+    - Masses in :math:`M_\odot / h`.
 """
 from argparse import ArgumentParser
 from datetime import datetime
@@ -75,6 +79,13 @@ def _main(nsim, simname, verbose):
         nsnap = -1
     part0, pid0 = partreader.read_particle(
         nsnap, nsim, pars_extract, return_structured=False, verbose=verbose)
+
+    # In CSiBORG we need to convert particle masses from box units.
+    if simname == "csiborg":
+        box = csiborgtools.read.CSiBORGBox(
+            max(paths.get_snapshots(nsim, simname)), nsim, paths)
+        part0[:, 3] = box.box2solarmass(part0[:, 3])
+
     # Quijote's initial snapshot information also contains velocities but we
     # don't need those.
     if simname == "quijote":